You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this PR is to deploy the routing/middleware layer in its own worker.
This should make cold start for ISR/SSG route that has been generated before really fast compared to now (On par or even better than in Vercel)
It requires #3265 to be merged before release.
The routing/middleware are in a separate worker. (ISR will be served from here)
The server and middleware worker are "linked" together. In preview, we use the preview url, in staging and prod, we use the Cloudflare-Workers-Version-Overrides headers (this requires the 2 versions to be uploaded first)
Deployment are now a multi step process to ensure that the middleware will always access the correct server
It doesn't use the binding anymore for the API, in some case it can cause a Response closed due to connection limit because the limit are shared between the workers and all its binding, especially for big pages. (This should close RND-7189)
This will also reduce memory consumption by the server worker since the middleware is in a different worker (it will help with RND-7141)
One of the downsides of this method is that changes to routes in wrangler.jsonc won't work automatically. It requires running wrangler triggers deploy
Also, we can't really test the Durable Object without deploying (DO don't work with preview url )
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Looking great 👌
Hopefully at some point the whole orchestration could be better handled at a lower level by opennext itself, but this should definitely be a great improvement in perfs for us
Hopefully at some point the whole orchestration could be better handled at a lower level by opennext itself, but this should definitely be a great improvement in perfs for us
Yeah this will get better, but to make it work in a more generic way, it requires a bunch of change, and not only to OpenNext
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conico974
changed the title
The goal of this PR is to deploy the routing/middleware layer in its own worker.
This should make cold start for ISR/SSG route that has been generated before really fast compared to now (On par or even better than in Vercel)
It requires #3265 to be merged before release.
Will close RND-7163
What's changed
Cloudflare-Workers-Version-Overridesheaders (this requires the 2 versions to be uploaded first)Response closed due to connection limitbecause the limit are shared between the workers and all its binding, especially for big pages. (This should close RND-7189)One of the downsides of this method is that changes to
routesinwrangler.jsoncwon't work automatically. It requires runningwrangler triggers deployAlso, we can't really test the Durable Object without deploying (DO don't work with
preview url)